google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
472 stars 189 forks source link

Check bundle optional for localized string #373

Open nrurnru opened 5 months ago

nrurnru commented 5 months ago

resolve https://github.com/google/GoogleSignIn-iOS/issues/309

Add optional check for bundle of framework. In this case UIAlertAction occurred crash because localizedStringForKey returned nil.

Swift version already has check this way. https://github.com/google/GoogleSignIn-iOS/blob/b45a83701141abde85a5e059a46b5ff039dca9ec/GoogleSignInSwift/Sources/GoogleSignInButtonStrings.swift#L41