search

google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
472 stars 189 forks source link

Calling GIDSignIn.sharedInstance.signIn, no callback is returned after successful authentication #377

Closed taro-ken closed 5 months ago

taro-ken commented 5 months ago

Describe the bug Calling GIDSignIn.sharedInstance.signIn, no callback is returned after successful authentication

To Reproduce Steps to reproduce the behavior:

  1. Press the GoogleLogin button and call the GIDSignIn.sharedInstance.signIn method
  2. Select a valid Google account and proceed
  3. permit access

Expected behavior Closure returns a signInResult.

Screenshots

https://github.com/google/GoogleSignIn-iOS/assets/67847164/40b18743-d6cc-481b-a1aa-5ddd0067e535

Environment

Additional context Pressing the GoogleLogin button to cancel the permission to share information dialog about apps and websites successfully returns an error in Closure.

mdmathias commented 5 months ago

I am not sure how the "GoogleLogin" button works. Ultimately, I think it would be that button's job to make sure that the closure is called. The sample apps in this library do not see this issue.

If you're able to reproduce this issue in one of our sample apps, please comment here with exact reproduction steps and we will investigate.