Closed mdmathias closed 2 months ago
In particular, the pod-lib-lint
job needs to look like this again:
pod-lib-lint:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [macos-12]
podspec: [GoogleSignIn.podspec, GoogleSignInSwiftSupport.podspec]
flag: [
"",
"--use-static-frameworks"
]
include:
- podspec: GoogleSignInSwiftSupport.podspec
includePodspecFlag: "--include-podspecs='GoogleSignIn.podspec'"
steps:
- uses: actions/checkout@v3
- name: Update Bundler
run: bundle update --bundler
- name: Install Ruby gems with Bundler
run: bundle install
- name: Lint podspec using local source
run: |
pod lib lint ${{ matrix.podspec }} --verbose \
${{ matrix.includePodspecFlag }} ${{ matrix.flag }}
Context
399 reverted
GoogleSignInSwiftSupport.podspec
's dependency on the GoogleSignIn pod to be 7.1+. This meant that the dependency for GSI inGoogleSignInSwiftSupport
in thefac-eap
branch did not match the version listed inGoogleSignIn.podspec
, which was"7.1.0-fac-beta-1.1.0"
.Problem
This mismatch, seemingly innocuous, led to
pod lib lint
failures (locally and PR runs) due to a version mismatch. Ultimately, the issue is that thepod lib lint
command passed in the localGoogleSignIn.podspec
, but lintingGoogleSignInSwiftSupport.podspec
would fail since the latter was looking for version 7.1+, andGoogleSignIn.podspec
listed version"7.1.0-fac-beta-1.1.0"
.To Do
399 resolved the issue by updating
unit_tests.yml
to not use the localGoogleSignIn.podspec
. This transformed the failing command:to this passing version:
When we merge
fac-eap
to themain
branch, we should reenable using the local podspec. We should also make sure that the version of GSI listed inGoogleSignInSwiftSupport.podspec
matches the version inGoogleSignIn.podspec
.