feat: allow providing custom nonce

google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.

https://developers.google.com/identity/sign-in/ios

Apache License 2.0

455 stars 181 forks source link

feat: allow providing custom nonce #402

Open vonovak opened 2 months ago

vonovak commented 2 months ago

Uses: https://github.com/openid/AppAuth-iOS/pull/788. Motivation is explained there and also in issue #135

Fixes: #135

Supersedes: #244. It takes a slightly different approach where nonce is not provided via GIDConfiguration but via a parameter to signInWithPresentingViewController/Window

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mdmathias commented 1 month ago

@vonovak did you sign the CLA? I can take a look at the PR after you confirm.

vonovak commented 1 month ago

hello @mdmathias yes I did! :)