search

google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.
https://developers.google.com/identity/sign-in/ios
Apache License 2.0
506 stars 201 forks source link

faulty "App wants additional access to your Google Account" prompt #457

Open vonovak opened 3 months ago

vonovak commented 3 months ago

Describe the bug Upon repeated sign in, the SDK shows a prompt that reads "App wants additional access to your Google Account" even though no extra access is being requested. This is highly confusing for users.

Issue is reproducible in the sample app.

screenshot ![Simulator Screenshot - iPhone 15 Pro Max - 2024-07-16 at 22 45 02](https://github.com/user-attachments/assets/af3add0e-5d29-41c4-8164-38b308577d4b)

To Reproduce Steps to reproduce the behavior:

See video

https://github.com/user-attachments/assets/3ef805e3-39de-473c-91b2-35afe30ef66b

Expected behavior

I don't expect to see the "App wants additional access to your Google Account" because I'm not asking for extra access.

Screenshots see above

Environment

gjbadros commented 3 months ago

Yes, this is a big deal and a regression compared to months ago where it unnecessarily scares users into thinking something funny/risky is going on. +1 for this being an important fix!

mdmathias commented 3 months ago

Thanks for the issue. We are investigating. I will update here as I learn more.

vsk-pvr commented 3 months ago

Same here

georgeselkhoury commented 3 months ago

same here. only on re-signing in. no changes in scope.

vonovak commented 3 months ago

It's clear at this point that there's an issue, and people are looking into it. Let's please not spam the issue and wait for actual updates. Thank you

tehsven commented 2 months ago

Hi @mdmathias thanks for looking into this. It's been over 2 weeks now - do you have any updates to share?

RaymRaym commented 2 months ago

Same here when using SwfitUI. Any updates?

mdmathias commented 5 days ago

Hi all. Sorry for the delay in responding. There are some moving pieces in the background that make this a little complicated. The video in the original issue above isn't playing for me any longer; so, I can't be quite sure what we were seeing there.

Nonetheless, if no new scopes are being requested, we shouldn't see "App wants additional access to your Google Account" any longer.

I've verified this in a sample app. I'll keep this open for a bit for y'all to let me know if you're seeing that too.

vonovak commented 5 days ago

👋 thanks for response, does this video link work?

mdmathias commented 5 days ago

Sadly no: "This private-user-images.githubusercontent.com page can’t be found"

vonovak commented 4 days ago

hello, I put it on YT: https://youtube.com/shorts/O88Dw8pfdYU