Clean up Model Conversion Script

google / JetStream

JetStream is a throughput and memory optimized engine for LLM inference on XLA devices, starting with TPUs (and GPUs in future -- PRs welcome).

Apache License 2.0

193 stars 24 forks source link

Clean up Model Conversion Script #131

Open yeandy opened 4 weeks ago

yeandy commented 4 weeks ago

Currently the model conversion script will create a bucket export MODEL_BUCKET=gs://${USER}-maxtext. However, it may be the case that the gs://${USER}-maxtext path already exists, which I imagine would break the script.

Solution: Be able to read in a few more arguments MODEL_BUCKET and BASE_OUTPUT_DIRECTORY. We should also delete references to DATASET_PATH.

JoeZijunZhou commented 4 weeks ago

If the bucket exists, the script will continue and use the existing ones IIRC. But feel free to refactor it to improve UX.

yeandy commented 3 weeks ago

If the bucket exists, the script will continue and use the existing ones IIRC

Yes, but only if the current USER is the original creator/owner of bucket, right? A different user could have the same value for USER, which I think would break the workflow.