google / TensorNetwork

A library for easy and efficient manipulation of tensor networks.
Apache License 2.0
1.82k stars 357 forks source link

MPS classes are not yet compatible with symmetric backend #515

Open mganahl opened 4 years ago

mganahl commented 4 years ago

the MPS classes rely on initializing new tensors from shapes of existing tensors, using Node.shape. This is not working for symmetric tensors. We need to add a sparse_shape attribute to Node, which returns an Index object for the case of the symmetric backend, and a plain integer for all others

chaserileyroberts commented 4 years ago

Good idea.

chaserileyroberts commented 4 years ago

This is fixed now right?

mganahl commented 4 years ago

No, not yet still need to fix the MPS

mganahl commented 4 years ago

that's actually a bit more work than I realized. For all mps classed to work properly we need to implement eigs into the symmetric backend. Should be relaitvely easy thoug.

chaserileyroberts commented 4 years ago

Is this done?

mganahl commented 4 years ago

No, this needs to fixed still