search

google / TensorNetwork

A library for easy and efficient manipulation of tensor networks.
Apache License 2.0
1.79k stars 352 forks source link

fix all pytorch tests #760

Open mganahl opened 3 years ago

mganahl commented 3 years ago

As of lately pytorch has complex number support. This means we have to fix the tests that were skipping pytorch on the ground that complex was not supported.

chaserileyroberts commented 3 years ago

Oh that's very exciting!

alewis commented 3 years ago

It seems that, while PyTorch does indeed have complex numbers now, many operations in practice choke on them. I'm still not totally sure of this though.

mganahl commented 3 years ago

It's still in beta I think. But my guess is that they'll further develop it. Quantum computing and classical simulation of circuits is growing more important, and I guess they want to stay competitive there as well.

glitch401 commented 3 years ago

Could I take up this, for my first contribution ?

alewis commented 3 years ago

This actually might be fixed and we just forget to close it - @mganahl ?

alewis commented 3 years ago

In the case that it is, #844 might be a good place to start? We'd be thrilled to have you!

Mahas1234 commented 3 months ago

Are there any more fixes needed. I'm looking for first contribution.