google / UIforETW

User interface for recording and managing ETW traces
https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/
Apache License 2.0
1.55k stars 201 forks source link

Minimize to system tray #109

Open zjturner opened 6 years ago

zjturner commented 6 years ago

It would be nice if we could minimize to system tray with a popup menu that would provide options for starting, stopping, and saving trace buffers

randomascii commented 6 years ago

Minimizing to the system tray seems problematic, based on the prototype I saw a few weeks ago. It made UIforETW "disappear" from its usual place on the task bar. It seems that the better thing to do would be to add a jumplist so that users could right-click on the existing icon to start/stop/save trace buffers. I would fully support that.

zjturner commented 6 years ago

It's possible to have a system tray icon as well as an app, but they may need to be 2 separate processes that communicate by ipc On Sun, Sep 17, 2017 at 7:55 PM Bruce Dawson notifications@github.com wrote:

Minimizing to the system tray seems problematic, based on the prototype I saw a few weeks ago. It made UIforETW "disappear" from its usual place on the task bar. It seems that the better thing to do would be to add a jumplist so that users could right-click on the existing icon to start/stop/save trace buffers. I would fully support that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/UIforETW/issues/109#issuecomment-330117977, or mute the thread https://github.com/notifications/unsubscribe-auth/ALRpScSeEiBJZzDky3gSymHS2YfsxamVks5sjdufgaJpZM4PaBqx .

randomascii commented 6 years ago

What is the advantage of having a system tray icon? If the goal is to have options for start/stop/save of trace buffers then a jumplist would offer that. Any alternative has to either be simpler to implement or offer better functionality.

zjturner commented 6 years ago

It's probably minor, but a system tray icon can

a) run at startup

b) not take up a slot on the taskbar (helpful if lots of apps are running simultaneously)

c) provide a little more flexibility than a jump list (e.g. You can have a context menu with submenus, for example to quickly load a trace in WPA with one click)

d) more informative from a UI perspective (eg you can change the icon depending on whether tracing is active or not)

None of these are make or break, so you may or may not consider it worth the effort On Sun, Sep 17, 2017 at 8:52 PM Bruce Dawson notifications@github.com wrote:

What is the advantage of having a system tray icon? If the goal is to have options for start/stop/save of trace buffers then a jumplist would offer that. Any alternative has to either be simpler to implement or offer better functionality.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/UIforETW/issues/109#issuecomment-330125109, or mute the thread https://github.com/notifications/unsubscribe-auth/ALRpSdCmge0z0beu4ZTk65hjFkacT1TDks5sjekLgaJpZM4PaBqx .

randomascii commented 6 years ago

On the downside it would mean that pinning UIforETW would no longer work as a way to be able to launch it. System tray area seems appropriate for things that are: a) Always running for the vast majority of users that run them b) Don't often require interaction (because tray icons are frequently hidden)

So, I'm currently not convinced. I definitely won't implement this, and the last patch I saw that tried to implement it made for very confusing behavior.

Jumplist menu would be very nice however, and some sort of progress bar indicator that could hint when tracing is running could be very nice.