search

google / UIforETW

User interface for recording and managing ETW traces
https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/
Apache License 2.0
1.55k stars 201 forks source link

Persist width and height of UIForETW #130

Closed chrdavis closed 5 years ago

chrdavis commented 5 years ago

This change implements the requested feature to persist the width and height of the UIForETW dialog. Setting is read during startup and applied to the dialog window upon initialization. I added a min size which is the default size of the dialog resource. I also added some arbitrary large max values for the width and height.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

chrdavis commented 5 years ago

updated

googlebot commented 5 years ago

CLAs look good, thanks!

randomascii commented 5 years ago

I left some comments on UIforETWDlg.h

chrdavis commented 5 years ago

I wasn't sure if the feature request also wanted to preserve the position as well as the width and height. Would require added code to handle checking valid coordinates and potential scale changes.

randomascii commented 5 years ago

Seems to work. Thanks for the contribution. Remembering position seems less important - it's often better to let Windows do its default behavior.