UIForETW silently exits if it cannot retrieve "My Documents" path

google / UIforETW

User interface for recording and managing ETW traces

https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/

Apache License 2.0

1.55k stars 201 forks source link

UIForETW silently exits if it cannot retrieve "My Documents" path #134

Open TautvydasZilys opened 5 years ago

TautvydasZilys commented 5 years ago

Relevant code:

https://github.com/google/UIforETW/blob/f91634529fc6bac025cec7ae7197a8431ab768c4/UIforETW/UIforETWDlg.cpp#L581

I was trying out UIForETW on my home machine after a recent boot and have not bitlocker unlocked all of my drives. My documents folder was under one such locked drive. I realize it is my fault for this, but at the very least UIForETW could have told me so, as I had to install a debugger just to figure out what's going on.

By the way: the same happens to WPRUI.exe :).

randomascii commented 5 years ago

Adding better error handling would be nice - a message box and then exit. This isn't a priority for me but if you want to create a PR I'd be happy to accept it.