google / UIforETW

User interface for recording and managing ETW traces
https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/
Apache License 2.0
1.55k stars 201 forks source link

Fix the locale dependent date parsing used for the output heap trace … #138

Closed lukastvrdy closed 4 years ago

lukastvrdy commented 4 years ago

…filename

date/T prints the date in locale-dependent format and thus causes issues when being parsed. wmic command works independently of OS locale, language or the user's chosen date format.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

lukastvrdy commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

randomascii commented 4 years ago

Sorry for the delayed response - I went on vacation the day you uploaded this. I'm hitting some problems with the find command but I think that's just because I've got a non-standard find command in my path. I will look more closely later.

randomascii commented 4 years ago

The find problem was unrelated. Merged