google / UIforETW

User interface for recording and managing ETW traces
https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/
Apache License 2.0
1.59k stars 201 forks source link

"partial" Python 3 support for StripChromeSymbols.py/fix `#include afxwin.h` #14

Closed ariccio closed 9 years ago

ariccio commented 9 years ago

This is actually a rather small PR, but because I moved the code in StripChromeSymbols.py into a main function, there are ~100 "additions" that aren't.

There are two components to this PR:

  1. Python 3 support for StripChromeSymbols.py
  2. A workaround for issue #13 - so that I can use UIforETW in the meantime.

The branch is called "switch-to-subprocess" because I originally thought that os.popen was the problem, and tried to solve it in 86cd03c299b70c521da2c534a5b3acc882de7bd8

I also moved #include <afxwin.h> to the top of stdafx.h, because some people (like me) can't compile MFC programs if it isn't the first include. I think it has something to do with Voodoo.

I've gotten used to it, but it is CRAZY HARD to actually figure out (that not including afxwin.h first) is generating 400 errors.

Strangely, GitHub converted eda1724b68fb1b2069a7258410316f989bd233a8, to link to https://github.com/google/UIforETW/commit/eda1724b68fb1b2069a7258410316f989bd233a8, and the same for 86cd03c299b70c521da2c534a5b3acc882de7bd8??!? What the hell?