search

google / UIforETW

User interface for recording and managing ETW traces
https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/
Apache License 2.0
1.55k stars 201 forks source link

Chrome special keyword flags are outdated #168

Open mstange opened 1 month ago

mstange commented 1 month ago

https://github.com/google/UIforETW/blob/3f33ef7207a7b9df2a4441d3b37e65ddcd274632/UIforETW/Settings.cpp#L66-L72 https://github.com/google/UIforETW/blob/3f33ef7207a7b9df2a4441d3b37e65ddcd274632/UIforETW/UIforETWDlg.cpp#L1171

These bits were changed in https://chromium-review.googlesource.com/c/chromium/src/+/2171974 :

Bits 61 and 62 are now bits 46 and 47. And the ORing with 0x8000000000000000 seems to no longer be suggested - I'm not sure why the old code said "Note that bit 63 (MSB) must always be set", it's possible that this was never true.