search

google / UIforETW

User interface for recording and managing ETW traces
https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/
Apache License 2.0
1.55k stars 201 forks source link

%etwtracedir% in etw_cpuusage_longterm.bat should be quoted #72

Closed ariccio closed 8 years ago

ariccio commented 8 years ago

These three lines:

@rem Make sure %etwtracedir% exists
@if exist %etwtracedir% goto TraceDirExists
@mkdir %etwtracedir%

should really be:

@rem Make sure %etwtracedir% exists
@if exist "%etwtracedir%" goto TraceDirExists
@mkdir "%etwtracedir%"

I'd submit a PR, but my local install of Git is acting up. Grr.

randomascii commented 8 years ago

Wow - lots of missing quotes. Dozens of them, in etwrecord.bat. I'm fixing and testing them all. Thanks for the report.

randomascii commented 8 years ago

Fixed, along with a host of related bugs, with commit cf5e5c954059d.