search

google / UIforETW

User interface for recording and managing ETW traces
https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/
Apache License 2.0
1.59k stars 201 forks source link

Don't hard code "C:" drive. #8

Closed vadz closed 9 years ago

vadz commented 9 years ago

The program refuses to start up on my machine where the Windows drive is "W:" and not "C:" because of the hard coded "C:" at

https://github.com/google/UIforETW/blob/cf3f8ee9c5d3d4014f93481c5bff0c6048f45c77/UIforETW/UIforETWDlg.cpp#L297

The code should really use SHGetKnownFolderPath().

randomascii commented 9 years ago

Confirmed. And easy to fix.

randomascii commented 9 years ago

Fixed with change 5ce43384dc0ed13196ab3712caf9c31f1c6350cb, which removes all hard-coded references to C:.

Note that for now you'll have to build from source to get this fix. Binary releases are intended to be less common.

randomascii commented 9 years ago

Fixed fix in change 408ed3a6fe0e6b003b3f71963dc25e4e26611a01. Now all is well.