google / UIforETW

User interface for recording and managing ETW traces
https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/
Apache License 2.0
1.57k stars 201 forks source link

Make flamegraph generation python script more flexible #82

Closed surki closed 8 years ago

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


surki commented 8 years ago

I signed it!

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

CLAs look good, thanks!

randomascii commented 8 years ago

Looks good! Can you add yourself to the AUTHORS and CONTRIBUTORS files and update this pull request with those changes? If you do it with --amend then the change will add most easily to the master branch. A more detailed description would also be nice, but isn't critical.

Thanks for contributing. And thanks googlebot for dealing with the CLA details.

surki commented 8 years ago

Updated. Thanks.

randomascii commented 8 years ago

Thanks for the change. I verified that it still works from the trace context menu. Now, if anyone wants to add some UI that will hook up the newly available options, that would be great.

Although, I hear rumors of flame graph support in future versions of WPA. Fingers crossed...