search

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

[CLOSED] Every sample should have the same look and feel #202

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by ianbarber Friday Apr 25, 2014 at 10:43 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/54

At the moment each sample set is using its own styling - these should be harmonised to be largely supplied by the templates, and reuse as much of the top level styling as possible.

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday Apr 28, 2014 at 08:58 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

@ianbarber can you make sure the getting started guide is excluded from this for the time being.

Thanks/

PaulKinlan commented 10 years ago

Comment by gauntface Monday Apr 28, 2014 at 09:01 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

@ianbarber what is your plan for doing this?

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday Apr 28, 2014 at 09:08 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

He has already done it.

On 28 April 2014 10:01, Matthew Gaunt notifications@github.com wrote:

@ianbarber https://github.com/ianbarber what is your plan for doing this?

— Reply to this email directly or view it on GitHubhttps://github.com/PaulKinlan/WebDocs/issues/54#issuecomment-41536648 .

PaulKinlan commented 10 years ago

Comment by ianbarber Monday Apr 28, 2014 at 09:30 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Not really. It's mainly porting the style guide over into the patternlab style, and setting some classnames where appropriate. I would like to include the getting started as well at least to some level so there is a consistency, but this is a v2 issue.