google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

[CLOSED] Vertical spacing of gray vs whitespace should be consistent within these boxes #216

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by maxh Friday Apr 25, 2014 at 16:12 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/68


image

PaulKinlan commented 10 years ago

Comment by peduarte Monday Apr 28, 2014 at 12:55 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


Hey,

The size of the gray bottom section varies depends on how much content is inside it.

Unfortunately, there isn't much I can do about this. I can see if there's a way to auto-adjust the height with flexbox, but not 100% sure.

I would recommend against setting a fixed height since this is responsive and we can never be sure of the length of the content inside, so we need to allow for wrapping.

Thanks Pedro

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday Apr 28, 2014 at 12:57 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


@meh - we might have to limit this to our three most important sections in each. Essentially these are quick links to the docs so you don't have to go in to the directory page.

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday Apr 28, 2014 at 12:58 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


In the case of media., we can put in a place holder

PaulKinlan commented 10 years ago

Comment by maxh Monday Apr 28, 2014 at 17:52 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


Limiting to 3 (or even 2) lines is fine.