search

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

[CLOSED] Vertical spacing of topical items on home page should be consistent #219

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by maxh Friday Apr 25, 2014 at 16:20 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/71

image

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday Apr 28, 2014 at 08:54 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

@andyhawkes this might be a duplicate.

PaulKinlan commented 10 years ago

Comment by peduarte Monday Apr 28, 2014 at 12:53 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Hey, yeah... CSS & vertical alignment. haha.

I am thinking of using flexbox as a progressive enhancement for this. On it.

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday Apr 28, 2014 at 12:55 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

:) so I think we can just put a new line in here, or set the text to min-heigh to be 2em..

PaulKinlan commented 10 years ago

Comment by PaulKinlan Tuesday Apr 29, 2014 at 06:47 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

I have a simpler solution about to land.

PaulKinlan commented 10 years ago

Comment by andyhawkes Wednesday Apr 30, 2014 at 08:37 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

This has been addressed editorially by @PaulKinlan - can we close this?

PaulKinlan commented 10 years ago

Comment by PaulKinlan Wednesday Apr 30, 2014 at 09:12 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Closing.