[CLOSED] Key Takeaways heading colour is not readable on pink background

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com

Apache License 2.0

13.85k stars 2.57k forks source link

[CLOSED] Key Takeaways heading colour is not readable on pink background #230

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by samdutton Monday Apr 28, 2014 at 12:23 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/82

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday Apr 28, 2014 at 12:40 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

This appears to be fixed on https://develop-dot-web-central.appspot.com/web/essentials/getting-started/multi-screen/content.html screen shot 2014-04-28 at 1 39 38 pm

Will put it on the list to check with agency

PaulKinlan commented 10 years ago

Comment by samdutton Monday Apr 28, 2014 at 14:55 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Yay!

On Mon, Apr 28, 2014 at 1:40 PM, Paul Kinlan notifications@github.comwrote:

This appears to be fixed on https://develop-dot-web-central.appspot.com/web/essentials/getting-started/multi-screen/content.html [image: screen shot 2014-04-28 at 1 39 38 pm]https://cloud.githubusercontent.com/assets/45510/2816954/3880c9c4-ced2-11e3-9bfc-da829380baa0.png

Will put it on the list to check with agency

— Reply to this email directly or view it on GitHubhttps://github.com/PaulKinlan/WebDocs/issues/82#issuecomment-41553153 .

PaulKinlan commented 10 years ago

Comment by peduarte Monday Apr 28, 2014 at 16:02 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Yeah, fixed that. Was being caused due to theming. Improved the markrup so it's more semantic too.

PaulKinlan commented 10 years ago

Comment by PaulKinlan Tuesday Apr 29, 2014 at 17:38 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Confirming this is fixed on the master branch now too. Thanks guys.