search

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

[CLOSED] Table headings should be left aligned #295

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by samdutton Wednesday Apr 30, 2014 at 09:39 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/147

image

PaulKinlan commented 10 years ago

Comment by peduarte Wednesday Apr 30, 2014 at 11:28 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Hello,

The tables were designed to support 4 columns, 3 columns and 2 columns, and the columns being equal widths.

The only 2 columns table that we have, both columns are 50%.

@PaulKinlan Can you let us know if we need a modifier for the 2 columns table? Maybe a table where the first column is 25% and the second is 75% width, instead of both being 50%.

Please refer to the styleguide in order to use the correct table markup: https://web-central.appspot.com/web/essentials/resources/styleguide/index.html#table

Currently, your table is missing the <colgroup> tag.

Thanks

PaulKinlan commented 10 years ago

Comment by PaulKinlan Wednesday Apr 30, 2014 at 11:50 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

@peduarte I don't think a modified table would solve this issue as the first column is wide in this case. I would leave for now.

@samdutton please add the colgroup.

samdutton commented 10 years ago

What I meant was that headings would look better if they were left aligned, so the th content was left aligned with the td content in the same column:

table th { text-align: left; }

The column width is not such a problem.

Why does this table need to use colgroup? There are lots of tables on the site without them (only one has them).

PaulKinlan commented 10 years ago

They should all follow the guidenlines set out by the agency.

On 9 May 2014 15:04, Sam Dutton notifications@github.com wrote:

What I meant was that headings would look better if they were left aligned, so the th content was left aligned with the td content in the same column:

table th { text-align: left; }

The column width is not such a problem.

Why does this table need to use colgroup? There are lots of tables on the site without them (only one has them).

— Reply to this email directly or view it on GitHubhttps://github.com/google/WebFundamentals/issues/295#issuecomment-42669224 .