search

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

[CLOSED] [BUG] Icons on Main page are different between browsers #312

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by KevinGeruldsen Thursday May 01, 2014 at 18:54 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/164

Found on: https://developers.google.com/web/fundamentals/

The icons that display in IE are different than what displays on any other browser.

IE Icons: googleieicons

Chrome Icons: googlechromeicons

PaulKinlan commented 10 years ago

Comment by PaulKinlan Friday May 02, 2014 at 08:11 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

It is a cross-origin font issue that we have a fix in progress for and shoudl already be deployed.

PaulKinlan commented 10 years ago

Comment by PaulKinlan Friday May 02, 2014 at 08:11 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

I suspect our IE fix hasn't landed yet...

PaulKinlan commented 10 years ago

Comment by andyhawkes Friday May 02, 2014 at 08:19 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

May also have been a font / css cache issue, as we pushed up that update last night which may have overlapped with the testing.

On 2 May 2014 09:11, Paul Kinlan notifications@github.com wrote:

I suspect our IE fix hasn't landed yet...

— Reply to this email directly or view it on GitHubhttps://github.com/PaulKinlan/WebDocs/issues/164#issuecomment-42001438 .

PaulKinlan commented 10 years ago

Comment by KevinGeruldsen Friday May 02, 2014 at 13:25 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

I no longer see this issue. Fixed

PaulKinlan commented 10 years ago

Comment by KevinGeruldsen Friday May 02, 2014 at 15:47 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

This issue is happening again. THe icons changed in FF and Chrome but did not change in IE

PaulKinlan commented 10 years ago

Comment by andyhawkes Friday May 02, 2014 at 15:49 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

It's a path issue - I forgot to replace the icon font path when I pushed an update to master.

On 2 May 2014 16:47, KevinGeruldsen notifications@github.com wrote:

This issue is happening again. THe icons changed in FF and Chrome but did not change in IE

— Reply to this email directly or view it on GitHubhttps://github.com/PaulKinlan/WebDocs/issues/164#issuecomment-42046091 .

PaulKinlan commented 10 years ago

Comment by KevinGeruldsen Monday May 05, 2014 at 19:50 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

This fix hasn't been pushed live correct? Because the icons are messed up on the live page currently.