search

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

[CLOSED] [BUG] Report an Issue image is inconsistent across browsers #314

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by KevinGeruldsen Friday May 02, 2014 at 13:32 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/166

Seen on: https://web-central.appspot.com/web/essentials/

The yellow image in the top right corner is inconsistent across browsers. The icon is rotating in Chrome but in no other browser.

See image spinning

PaulKinlan commented 10 years ago

Comment by peduarte Friday May 02, 2014 at 13:36 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Hello,

The only browser prefix we are targeting is -webkit.

So, this will only work on browsers that support unprefixed css animation/keyframes or webkit browsers.

@PaulKinlan can you confirm that this is ok? Or would you like me to add other browser prefixes?

PaulKinlan commented 10 years ago

Comment by peduarte Tuesday May 06, 2014 at 15:22 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

@andyhawkes can you please advise?

PaulKinlan commented 10 years ago

Comment by andyhawkes Tuesday May 06, 2014 at 15:49 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

That's fine as a progressive enhancement / minor embelishment for capable browsers - it doesn't have to spin in all browsers.

On 6 May 2014 16:22, Pedro notifications@github.com wrote:

@andyhawkes https://github.com/andyhawkes can you please advise?

— Reply to this email directly or view it on GitHubhttps://github.com/PaulKinlan/WebDocs/issues/166#issuecomment-42316592 .

PaulKinlan commented 10 years ago

Comment by KevinGeruldsen Tuesday May 06, 2014 at 15:51 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

can we close this issue then?

PaulKinlan commented 10 years ago

Comment by andyhawkes Tuesday May 06, 2014 at 15:53 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Happy for that to be closed

On 6 May 2014 16:51, KevinGeruldsen notifications@github.com wrote:

can we close this issue then?

— Reply to this email directly or view it on GitHubhttps://github.com/PaulKinlan/WebDocs/issues/166#issuecomment-42320699 .

PaulKinlan commented 10 years ago

Comment by KevinGeruldsen Tuesday May 06, 2014 at 15:54 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

done!