google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

[BUG][Mobile] Labels missing on chart #315

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by KevinGeruldsen Friday May 02, 2014 at 18:29 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/167


Seen on: https://web-central.appspot.com/web/essentials/documentation/performance/optimizing-content-efficiency/index.html

The chart on the link above looks like it is missing the labels on the Left. When in desktop size it has labels for the 50th, 75th and 90th percentiles.

See screenshot: googlelabels

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday May 05, 2014 at 16:26 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


@igrigorik will probably need to make the table with the correct headings.

PaulKinlan commented 10 years ago

Comment by PaulKinlan Monday May 05, 2014 at 16:27 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


@igrigorik for context, the tables need a special data attribute to work correctly.

PaulKinlan commented 10 years ago

Comment by igrigorik Wednesday May 07, 2014 at 22:25 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


@PaulKinlan it renders correctly on my local instance (latest checkout)

image

What am I missing? Why is the build on d.g.com showing different results?

PaulKinlan commented 10 years ago

Comment by KevinGeruldsen Thursday May 08, 2014 at 13:07 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


@igrigorik Your screenshot is of either tablet or desktop size, the bug is for Mobile only

PaulKinlan commented 10 years ago

Comment by KevinGeruldsen Thursday May 08, 2014 at 13:10 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


This is what I see on web-central and develop-dot googlechart

PaulKinlan commented 10 years ago

Comment by ianbarber Thursday May 08, 2014 at 14:08 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


It does seem to do the right thing in the visual style guide, but that doesn't have the markdown to accomplish the same thing. I notice there is a colgroup in there, not sure if that's involved: https://web-central.appspot.com/web/essentials/resources/styleguide/index.html#table

KevinGeruldsen-RGA commented 10 years ago

This is fixed