search

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

[CLOSED] [BUG] Text is cutoff in chart at certain browser size #317

Closed PaulKinlan closed 10 years ago

PaulKinlan commented 10 years ago

Issue by KevinGeruldsen Monday May 05, 2014 at 14:53 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/PaulKinlan/WebDocs/issues/169

Seen on: https://web-central.appspot.com/web/essentials/documentation/user-input/form-input/index.html

When my browser is at a width of 589 and lower, the text on some of the sections of the first chart is cutoff at the bottom.

See screenshot googlerunoff

PaulKinlan commented 10 years ago

Comment by peduarte Tuesday May 06, 2014 at 10:59 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Hey @antoinegrelard, can you have a look at this, please?

PaulKinlan commented 10 years ago

Comment by antoinegrelard Tuesday May 06, 2014 at 15:47 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

The main issue is that the height is proportionate to the content of the table, and not of the titles on the right (which are pseudo elements), so when the content only take one line each, the title can be cut off at the end of the tr. There is no way to fix it, but I tweaked it so that it works with a "two lines" title, so please try to make sure that your titles doesn't go on three lines on mobile, otherwise it will break again.

@andyhawkes can you make sure this is a good fix?

PaulKinlan commented 10 years ago

Comment by peduarte Friday May 09, 2014 at 12:35 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT

Yeah, this should be good.

@PaulKinlan Just as a side note for you, need to make the authors aware of this. We added min-height equivalent to two lines of text.