search

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.56k forks source link

Podcast XML Feed Error #4324

Closed mustafa-x closed 7 years ago

mustafa-x commented 7 years ago

The XML feeds generated seem to pull in some errors when displayed in iTunes. The image appears in the description as HTML. screen shot 2017-03-16 at 12 05 25 pm

paullewis commented 7 years ago

The problem seems to be this line here: https://github.com/google/WebFundamentals/blob/master/src/templates/shows/podcast.xml#L24

@petele Am I right you did this work? Git blame implies it, but I figure it may be an artifact of merging other things and so on.

petele commented 7 years ago

yep - did the work, prob won't have time to fix or investigate until next week when back state side, so feel free to attempt to fix if it's it really bugs ;)

paullewis commented 7 years ago

Well the fix looks straight forward, insofar as removing the image from the template... I guess I was wondering if there's a reason it's in there?

petele commented 7 years ago

It was in there because we use the imgs for analytics, but on investigation, iTunes doesn't allow any images in the description. I've fixed and cleaned up the feeds a bit.

paullewis commented 7 years ago

Thank you sir! 👍

mustafa-x commented 7 years ago

Thank you Pete!!