search

google / WebFundamentals

Former git repo for WebFundamentals on developers.google.com
Apache License 2.0
13.85k stars 2.57k forks source link

Workbox swDest references are inconsistent #7369

Open philipwalton opened 5 years ago

philipwalton commented 5 years ago

Reported on twitter: https://twitter.com/marcushellberg/status/1103827852552736768

@jeffposnick it looks like many of our build tool docs share config partials. I believe workbox-webpack-plugin is the only one that defaults to a particular swDest option. Can you confirm?

If so, any objection to just changing all of our swDest examples to be service-worker.js?

jeffposnick commented 5 years ago

That's correct; only the webpack plugin has a default swDest filename—because webpack can infer the output path. The other build tools need you to provide output info.