search

google / Xee

An Xarray extension for Google Earth Engine
https://xee.rtfd.io
Apache License 2.0
251 stars 29 forks source link

transform dataset coordinates into specified crs #97

Closed boothmanrylan closed 10 months ago

boothmanrylan commented 11 months ago

Fixes #96

boothmanrylan commented 11 months ago

I believe I fixed the linting issues, but the tests were failing on the Authenticate to Google Cloud step with:

Error: google-github-actions/auth failed with: retry function failed after 4 attempts: the GitHub Action workflow must specify exactly one of "workload_identity_provider" or "credentials_json"! If you are specifying input values via GitHub secrets, ensure the secret is being injected into the environment. By default, secrets are not passed to workflows triggered from forks, including Dependabot.

And I don't know how to fix that, I'm not very familiar with github actions or secrets, so any suggestions would be appreciated.

naschmitz commented 11 months ago

@boothmanrylan Could you sync and resolve the conflicts? Then, I should be able to approve your CL and run the integration tests.

boothmanrylan commented 11 months ago

@naschmitz I believe I have addressed your requested changes, please let me know if you need more information or if there are other changes I need to make.

boothmanrylan commented 10 months ago

Hi @dabhicusp I can switch that pixelLonLat to pixelCoordinates, but I'm not sure it is necessary. As far as I can tell that pixelLonLat is just being used to create an image collection with known values to be used in tests e.g. getting the first element of the array and expecting the value to be -179.5

Also, all of the tests that use it are passing for me locally with my changes.