google / acai

Testing library for JUnit4 and Guice.
Apache License 2.0
76 stars 29 forks source link

Replace BeforeSuite, BeforeTest, and AfterTest with JUnit BeforeClass, Before, and After annotations #26

Open BenEast opened 5 years ago

BenEast commented 5 years ago

Replace BeforeSuite, BeforeTest, and AfterTest with JUnit BeforeClass, Before, and After annotations.

Updated unit tests to reference the correct annotations as well. At this point I've completely removed the custom annotations. If preferred, I can make some changes to deprecate, but still support, the old annotations.

Related to issue #3

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

BenEast commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.