search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

[WebView] Fixed sizing bug when showing a website that isn't covering all screen #1515

Closed alirahimpour89 closed 1 year ago

alirahimpour89 commented 1 year ago

Since you added a frame layout around the webview some websites have started get weird sizing problems. The problem is visible on websites that isn't that tall and doesn't need scrolling. This PR fixes that issue.

I can also add that I think this can be simplified by setting match parent on the WebView and only use the height and width variables for the frame layout but don't know if the WebView would react differently then but I think that should work.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.