search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

Introduce Navigation Material for M3 #1543

Closed jossiwolf closed 7 months ago

alirahimpour89 commented 1 year ago

I know it's just a draft but would be nice to be able to override the confirmValueChange too. I am doing that in an app with the old version and would have to rewrite a lot if we loose that possibility.

jossiwolf commented 1 year ago

We're not considering this as it could impact state synchronization. I believe there is an upstream ticket to track adding a sheetGesturesEnabled parameter though which we would then expose.

alirahimpour89 commented 1 year ago

That would be great!

phucynwa commented 1 year ago

I have 2 requests:

  1. I tried to implement this method, however, the bottom sheet is not full screen. Could you find a way to fix this?
  2. Please resolve the conflicts. 😄
alirahimpour89 commented 1 year ago

Any progress on this one? Really looking forward to it

FunkyMuse commented 1 year ago

is there any update on this?

kataRebuy commented 7 months ago

Any updates on this? The only material dependency I am using in my app is the bottom sheet and it is getting annoying to always be on the lookout for material imports instead of material3.

harry248 commented 7 months ago

Has this been abandoned? We can't migrate completely to M3 because of this library. Would be nice if we had some info if it is worth waiting or if it would be better to throw out Accompanist Navigation.

ianhanniballake commented 7 months ago

With the release of Compose Material 1.7.0-alpha04, the Material team has added a new artifact: androidx.compose.material:material-navigation, which fully replaces Accompanist Navigation Material.

As such, we are closing all PRs here on Accompanist. Any future work in this space will be done as part of the androidx.compose.material3 or related artifacts.