search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

[Navigation Material] Multiple BottomSheets on top of each other #1548

Closed MarcLFJ closed 1 year ago

MarcLFJ commented 1 year ago

Description When navigating from BottomSheet to BottomSheet, I can't find a handle to display the new sheet on top of the old one. Currently the old sheet animates as if dismissed and then the new destination is shown. Looking into the source code, it seems like the in BottomSheet i reused and content is swapped, when it's off screen. Are there any plans on supporting multiple BottomSheets on top of each other (e.g not animating it out) or is this out of scope/not the intended usecase for navigation in material3?

Steps to reproduce Setup Navigation Graph with multiple bottomsheet and navigate from one bottomsheet destination to another.

Expected behavior The new BottomSheet destination to be displayed on top of the old one, instead of the old destination animating out.

Additional context

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

gabrielittner commented 1 year ago

This is still relevant

MarcLFJ commented 1 year ago

@jossiwolf this is still relevant 🙂

Mwhite69 commented 1 year ago

How do i fix the problem mark whit3

On Sat, May 13, 2023, 2:08 AM Marc le Fevre Johansen < @.***> wrote:

@jossiwolf https://github.com/jossiwolf this is still relevant 🙂

— Reply to this email directly, view it on GitHub https://github.com/google/accompanist/issues/1548#issuecomment-1546539625, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6VPCDURFKXQBARSQAZZ2EDXF4QOHANCNFSM6AAAAAAWA26CXY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

victor-munoz commented 1 year ago

can we open this ticket?