search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

Rollback navigation upgrade to latest stable #1554

Closed bentrengrove closed 1 year ago

bentrengrove commented 1 year ago

Fixes #1552

bentrengrove commented 1 year ago

Looks like that gradle issue still exists. @jossiwolf, you need 2.6.0 for your work right?

jossiwolf commented 1 year ago

@bentrengrove I don't think we need any APIs or features specifically, but there have been quite a few important bugfixes. Tbh I think it's fine to depend on an alpha version in Accompanist, we do the same with other AndroidX dependencies. Do you think we should depend on a stable Nav version instead?

cc @jbw0033

G00fY2 commented 1 year ago

@jossiwolf I heavily disagree on using transitive unstable dependencies in stable releases. Thats also not the case for any other Google library I am aware of. The consumers should decide whether the bugfixes are important and justify using alpha releases.

We e.g. use this check (inspired by a discussion in the Gradle forum). The latest Accompanist release is the only dependency (also for the first time since we added this check a year ago) which causes a violation in our project with 150+ explicitly declared dependencies.

JohannesPtaszyk commented 1 year ago

Have to agree with @G00fY2. Transitive unstable dependencies in stable releases should be disallowed.

bentrengrove commented 1 year ago

We will be rolling back the navigation dependency to the last stable version and doing another Accompanist stable release.

serhii-pokrovskyi commented 1 year ago

We will be rolling back the navigation dependency to the last stable version and doing another Accompanist stable release.

any chances that this will fix? I think that they are related

1558