search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

[Adaptive] Migrate gradle module til Kotlin DSL #1579

Closed oas004 closed 1 year ago

oas004 commented 1 year ago

This is the first PR in a series to migrate the gradle files to use Kotlin DSL instead of Groovy. Since having Kotlin DSL and Groovy in the same project works fine, I thought migrating module by module was okay.

The related issue is #1578.

I have split up the PR into two commits. The first one prepares the file to be migrated by using steps described in these docs. The second one is where I actually convert the file to .kts file and updates the rest of the file to be compatible with Kotlin DSL.

I have added a line to suppress unstable API usage, since a lot of the APIs here are marked incubating. What do you guys think about that?

bentrengrove commented 1 year ago

Thank you for these! Sorry I have been slow to review, I have been OOO this week. Just catching up but should be able to get to them soon.

oas004 commented 1 year ago

Thank you for these! Sorry I have been slow to review, I have been OOO this week. Just catching up but should be able to get to them soon.

No worries at all! Take your time! :)

bentrengrove commented 1 year ago

This just needs rebasing I think. Can you please rebase and reopen a PR when ready?

oas004 commented 1 year ago

Ah yes, I'm not quite sure why this build before we bumped AGP 8.0.0, but I had to revert the Java target version in this module to 1.8 to get it to compile. I think this is because we are setting 1.8 in project gradle. Maybe it makes sense to migrate everything there to 11 in bulk? Sorry about this, I should have rebased it before and checked. Reopened a PR here https://github.com/google/accompanist/pull/1593