search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

[Navigation Material] Please add the option to skip the bottom sheet close animation #1600

Closed Monabr closed 1 year ago

Monabr commented 1 year ago

HI! Please add more options to customize the animation, such as the ability to turn off the bottom sheet closing animation.

It would help me a lot and I can't find a way to do it myself unfortunately.

ianhanniballake commented 1 year ago

You want the bottom sheet to just...disappear completely via a jump cut?

Monabr commented 1 year ago

Yes, I want to customize the animation. One option: just disappear without moving. Perhaps by changing the transparency.

One of the reason - laggy animation. I see this animations on my divice like this: closing, pause, closing, pause, closing. And I realy don't like that.

ianhanniballake commented 1 year ago

Bottom sheets are Material 2 spec and Material3 spec, which is very opinionated on how they animate, so the lack of customization for bottom sheet animations is working as intended.

I'd suggest filing any performance issues against the Compose Material library directly with a sample project that shows your laggy animation. Accompanist is not writing any animation code at all, just using what the Compose Material library is providing, so any fixes in the animation lag would need to be done at that level.