search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

Create a BOM for the accompanist libraries #1608

Closed OliverRhyme closed 1 year ago

OliverRhyme commented 1 year ago

Describe the bug

Adding a BOM to accompanist can improve the maintainability of the versions.

Expected behavior (if applicable)

A BOM is available

Additional context

This will ease the versioning of the accompanist libraries (dev side) and reduces the chances of importing a wrong version and possibly inflating the APK.

bentrengrove commented 1 year ago

Accompanist libraries are all versioned as one, I'm not sure what this would actually help with? Can you give a more specific example please?

OliverRhyme commented 1 year ago

Accompanist libraries are all versioned as one, I'm not sure what this would actually help with? Can you give a more specific example please?

Same scenario with jetpack compose libraries. It is versioned as one but it is much easier with the BOM. We can also maybe ease the version matching of accompanist with jetpack compose by just by matching the BOM versions

bentrengrove commented 1 year ago

The Compose libraries are actually versioned separately now which was the inspiration for adding the BOM, for example Compose m3 is on 1.1.0 where as the rest are on 1.5.0. We also anticipate there will be more divergence as time goes on. We also couldn't keep a BOM version number in sync with the Compose libraries to make matching easier because we release on different schedules unfortunately.

I will close this for now but if other people feel strongly about this then please do comment.