google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

Migrate AGP from 8.0.0 to 8.0.1 #1617

Closed stevan-milovanovic closed 1 year ago

stevan-milovanovic commented 1 year ago

Following up https://github.com/google/accompanist/issues/1616

Migrating AGP from 8.0.0 to 8.0.1 and resolving TODO: Remove when fixed https://github.com/gradle/gradle/issues/24037

bentrengrove commented 1 year ago

Thanks for the contribution! We are currently in the process of migrating to kts gradle files as part of #1578 but I don't see why we can't merge this in the mean time.

Please just fix up that merge conflict

stevan-milovanovic commented 1 year ago

You're welcome. Sounds good 👍 I fixed them up, should be good to go 😄

stevan-milovanovic commented 1 year ago

@bentrengrove sorry for the delay, I updated the changes.

bentrengrove commented 1 year ago

Sorry, as mentioned you are working at the same time as the migration to KTS so this now conflicts again. I might close this for now unfortunately as by the end of the migration the bump from 8.0.0 to 8.0.1 should be trivial