search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

[Permissions-Lint] Migrate gradle file to Kotlin DSL #1631

Closed oas004 closed 1 year ago

oas004 commented 1 year ago

Following up https://github.com/google/accompanist/issues/1578 and relating to https://github.com/google/accompanist/pull/1579

Migrating the :permissions-lint module to Kotlin DSL.

I have split up the PR into two commits. The first one prepares the file to be migrated by using steps described in these docs. The second one is where I actually convert the file to .kts file and updates the rest of the file to be compatible with Kotlin DSL.

oas004 commented 1 year ago

Can we try to rerun the unit tests for this? From the log I think maybe the the issue was that the maven server returned 502 🤔 

Caused by: java.util.concurrent.ExecutionException: java.io.IOException: Server returned HTTP response code: 502 for URL: https://repo1.maven.org/maven2/org/robolectric/android-all-instrumented/13-robolectric-9030017-i4/android-all-instrumented-13-robolectric-9030017-i4.pom
    at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:588)
    at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:567)
    at com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:113)
    at org.robolectric.internal.dependency.MavenArtifactFetcher.fetchArtifact(MavenArtifactFetcher.java:99)
oas004 commented 1 year ago

Rebased this with main now, sorry for not attending this PR, but now that Manuel is leaving google (https://twitter.com/manuelvicnt/status/1706651911569420512?t=pkAyynIoguUSvnmjkPlgNg&s=19) is it possible that someone else might give this a review? :)