google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.34k stars 593 forks source link

[Navigation Material] crash after upgrade to compose 1.5.0-beta01 #1636

Closed ti4n1993 closed 1 year ago

ti4n1993 commented 1 year ago
java.lang.NoSuchMethodError: No static method ModalBottomSheetLayout-BzaUkTc(Lkotlin/jvm/functions/Function3;
Landroidx/compose/ui/Modifier;
Landroidx/compose/material/ModalBottomSheetState;
Landroidx/compose/ui/graphics/Shape;
FJJJLkotlin/jvm/functions/Function2;
Landroidx/compose/runtime/Composer;II)V in class Landroidx/compose/material/ModalBottomSheetKt;
 or its super classes (declaration of 'androidx.compose.material.ModalBottomSheetKt' appears in package-name
at com.google.accompanist.navigation.material.BottomSheetKt.ModalBottomSheetLayout-4erKP6g(BottomSheet.kt:48)
MarcLFJ commented 1 year ago

Having the same issue: androidx.compose.material3:material3:1.2.0-alpha02 Compose: 1.5.0-beta01 Accompanist: 0.31.2-alpha

miduch commented 1 year ago

+1

SpiritualForest commented 1 year ago

I'm also affected

javichaques commented 1 year ago

+1

hovadur commented 1 year ago

+1

Monabr commented 1 year ago

+1 please fix!

bentrengrove commented 1 year ago

This doesn't seem to reproduce in the sample app just by upgrading to 1.5.0-beta01. Does anyone else have any info? Does this just happen as soon as you show a bottom sheet?

Monabr commented 1 year ago

@bentrengrove This happens when you try to run the application. My project uses navigation to the bottom sheet and, accordingly, ModalBottomSheetLayout. I think it’s at this moment everything falls down, because when I start the application, I don’t call the bottom sheet itself, only by clicking, but it doesn’t reach it (moment for clicking), because the application crashes before that (immediately at startup)

bentrengrove commented 1 year ago

I assume this is just a binary incompatible change then, I will do a release with an upgraded Compose which should fix it

bentrengrove commented 1 year ago

This has been released as v0.31.3-beta. Please let me know if the issue continues

SpiritualForest commented 1 year ago

Just reporting that the latest version fixed it for me. Thanks @bentrengrove 👍

MarcLFJ commented 1 year ago

Same - works for me now, @bentrengrove! 🙌

dwane13 commented 1 year ago

Still reproduces on 0.31.5 with compose 1.5.0-beta03 , @bentrengrove

Palmer1985 commented 10 months ago

https://github.com/google/accompanist/issues/1713 Please help this issue How could I solve it.