search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

[Navigation-animation] Delegate navigation-animation impl to androidx navigation #1645

Closed claraf3 closed 1 year ago

claraf3 commented 1 year ago

With navigation-animation migrated back to androidx navigation, we are deprecating accompanist navigation-animation with first step as delegating its implementation to androidx navigation.

Source breaking change -- navigation-animation migrated all internal usages of AnimatedComposeNavigator to ComposeNavigator. This means by default, animated NavHostController will only contain ComposeNavigator and no longer contain any AnimatedComposeNavigator. Code references to AnimatedComposeNavigators such as its retrieval from navigatorProvider may be impacted if none were manually added.

Test: ./gradlew navigation-aninmation:cC Issue: #1646

ianhanniballake commented 1 year ago

Looks like you'll need to run ./gradlew :navigation-animation:spotlessApply to apply the formatting fixes before this can be merged in.