search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.38k stars 596 forks source link

[WebView] Nestedscroll Does not work in Compose WebView #1652

Closed KevinnZou closed 1 year ago

KevinnZou commented 1 year ago

Description In this PR:https://github.com/google/accompanist/pull/1483, the webview is now wrapped with a Framelayout and then returned to AndroidViewHolder. However, the AndroidViewHolder use view?.isNestedScrollingEnabled to determine whether the child view support nested scroll. It works well before this change because Webview supports nested scroll but failed now since FrameLayout does not.

Steps to reproduce Just use the webview with a container that has some nested scroll logic, and you will see the abnormal behaviors.

Expected behavior The nested scroll should work well like the version before this pr

Additional context Please let me know if there is any workaround for that problem.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

KevinnZou commented 1 year ago

Is there any update on this issue?

bentrengrove commented 1 year ago

No update sorry, but if anyone would like to submit a PR to remove the FrameLayout I would accept that as a contribution.

KevinnZou commented 1 year ago

I would like to do that. But how to handle the issue that made you add that Framelayout? https://issuetracker.google.com/issues/243567497

bentrengrove commented 1 year ago

I think this issue is greater than that one so we can open a new issue for it here

KevinnZou commented 1 year ago

Okay! I will try to submit a PR to remove the FrameLayout.

KevinnZou commented 1 year ago

https://github.com/google/accompanist/pull/1684 Hi Ben, I just removed the FrameLayout and submitted the PR. Please let me know if there is anything else that need to do.