google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

[WebView] Modifier pullRefresh not work for WebView #1670

Closed ssujr closed 1 year ago

ssujr commented 1 year ago

Trying to add Modifier.pullRefresh() to WebView as below which is not working.

val navigator = rememberWebViewNavigator() val state = rememberWebViewState(url = "https://www.google.com") val scope = rememberCoroutineScope() fun refresh() = scope.launch { navigator.reload() } val refreshState = rememberPullRefreshState(isLoading, ::refresh) ` WebView( modifier = Modifier.fillMaxSize().pullRefresh(refreshState), state = state, navigator = navigator )`

bentrengrove commented 1 year ago

Please try this again in the latest release, this should have been fixed by #1684

ssujr commented 1 year ago

Tried v0.31.6-rc. androidx.compose.material.pullrefresh is still not working.

bentrengrove commented 1 year ago

Unfortunately Accompanist WebView has been deprecated and won't be supported going forwards. I am closing this issue. We recommend you fork the implemenation here and customise it to your needs. For more information please see our update blog