search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.43k stars 598 forks source link

[WebView] ✨ Expose the postUrl function via the WebView Composable #1677

Closed MaxMichel2 closed 1 year ago

MaxMichel2 commented 1 year ago

Adds the postUrl function to the WebView

Fixes #1612

bentrengrove commented 1 year ago

Thanks for this contribution, it's looking good! We would also need a test please to be able to merge this

MaxMichel2 commented 1 year ago

Hey @bentrengrove,

I totally forgot about the test! That's my bad. It should be added now so feel free to check and come back to me with other changes if required.

MaxMichel2 commented 1 year ago

It seems like the build failed for some reason. I'm not too sure on why that is however. I can take a look at the code if required 🤔

bentrengrove commented 1 year ago 
e: file:///home/runner/work/accompanist/accompanist/web/src/main/java/com/google/accompanist/web/WebView.kt:332:5 Visibility must be specified in explicit API mode

e: file:///home/runner/work/accompanist/accompanist/web/src/main/java/com/google/accompanist/web/WebView.kt:577:5 Visibility must be specified in explicit API mode
e: file:///home/runner/work/accompanist/accompanist/web/src/main/java/com/google/accompanist/web/WebView.kt:700:1 Visibility must be specified in explicit API mode

It's running in explicit API mode so you probably just have to add public to all your assumed public methods and classes.

MaxMichel2 commented 1 year ago 
e: file:///home/runner/work/accompanist/accompanist/web/src/main/java/com/google/accompanist/web/WebView.kt:332:5 Visibility must be specified in explicit API mode

e: file:///home/runner/work/accompanist/accompanist/web/src/main/java/com/google/accompanist/web/WebView.kt:577:5 Visibility must be specified in explicit API mode
e: file:///home/runner/work/accompanist/accompanist/web/src/main/java/com/google/accompanist/web/WebView.kt:700:1 Visibility must be specified in explicit API mode

It's running in explicit API mode so you probably just have to add public to all your assumed public methods and classes.

It seems as though the lines don't reference anything specific on my side... You can check the lines in the PR but 332, 577 and 700 don't point to anything where I could add the public keyword unfortunately

I've tried running the build as configured in the github actions on my side and it works just fine so I'm wondering if I'm missing a config that you may have locally 🤔

I also tried adding the explicit API mode locally but this seems to want keywords in many more places that what the build currently reports.

All help on this issue would be appreciated since I'd like to get this added soon ^^

@bentrengrove, could you try to re-run the job and if it fails again, I'll try to see what's going on on my side