search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.31k stars 592 forks source link

False positive deprecation message on pagerTabIndicatorOffset variant #1739

Closed PhilipDukhov closed 4 months ago

PhilipDukhov commented 6 months ago

The deprecation message for the method indicates that the androidx.compose.foundation.pager.PagerState version should be used.

However, this applies to both versions of the modifier, including the one already using androidx.compose.foundation.pager.PagerState. The message seems to suggest an alternative that is essentially the same as the current implementation.

https://github.com/google/accompanist/blob/3af68c89ca6686b4b611f41e8d5e8cffe5f4b56e/pager-indicators/src/main/java/com/google/accompanist/pager/PagerTab.kt#L63-L73

joshrvezy commented 5 months ago

ive also noticed this as well

bentrengrove commented 4 months ago

This was deprecated on purpose. I will update the docs.

We won't be updating it going forwards so we recommend just copying the implementation to your own project.