search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.31k stars 592 forks source link

Incorrect deprecation of pagerTabIndicatorOffset #1744

Closed zsperske closed 4 months ago

zsperske commented 5 months ago

Describe the bug

The deprecation message of pagerTabIndicatorOffset says to use androidx.compose.foundation.pager.PagerState, despite the version in question already using it.

@OptIn(ExperimentalFoundationApi::class)
@Deprecated(
    """
   pagerTabIndicatorOffset for accompanist Pagers are deprecated, please use the version that takes 
   androidx.compose.foundation.pager.PagerState instead
For more migration information, please visit https://google.github.io/accompanist/pager/#migration
"""
)
public fun Modifier.pagerTabIndicatorOffset(
    pagerState: androidx.compose.foundation.pager.PagerState, // this is already using the foundation PagerState
    tabPositions: List<TabPosition>,
    pageIndexMapping: (Int) -> Int = { it },
): Modifier {
    ...
}
carstenhag commented 3 months ago

Doesn't seem to be release yet

carstenhag commented 2 months ago

@bentrengrove et al, can you please release a new version so this doesn't show up anymore? :) Thanks!

bentrengrove commented 1 month ago

Done! Sorry for the delay