search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.42k stars 597 forks source link

[pager-indicators] Drop false-positive deprecation of pagerTabIndicatorOffset() #1755

Closed Philipp91 closed 7 months ago

Philipp91 commented 7 months ago

Fixes #1744.

The deprecation was intended to apply only to the old overload above, but was presumably copy-pasted by accident.

bentrengrove commented 7 months ago

Actually sorry, I just remembered this was deprecated on purpose. We need to update the docs.

We recommend just copying the implementation to your project as our implementation isn't maintained going forwards.

joshrvezy commented 7 months ago

Actually sorry, I just remembered this was deprecated on purpose. We need to update the docs.

We recommend just copying the implementation to your project as our implementation isn't maintained going forwards.

when you deprecate it, is there a migration strategy in place for whatever we are supposed to do to keep using indicators? thanks

bentrengrove commented 7 months ago

More details here. For pager indicators the recommendation is just to copy the implementation into your own project and customize to your needs

https://medium.com/androiddevelopers/an-update-on-jetpack-compose-accompanist-libraries-august-2023-ac4cbbf059f1

Philipp91 commented 7 months ago

I believe an important (and correct?) piece of background information is that TabRow(indicator=...) and ScrollableTabRow(indicator=...) now have decent default values. So one does not need to call pagerTabIndicatorOffset() manually in order to get a reasonably working TabRow.