search

google / accompanist

A collection of extension libraries for Jetpack Compose
https://google.github.io/accompanist
Apache License 2.0
7.48k stars 602 forks source link

BottomSheetState's progress on BottomSheetScaffold #1782

Closed honeywhisperer closed 4 months ago

honeywhisperer commented 4 months ago

Describe the bug

progress value from BottomSheetState on BottomSheetScaffold is being continuously updating when bottom sheet is changing state from expanded to collapsed; while dragging bottom sheet to expand, progress only shows 1.0 once bottom sheet is fully expanded.

To Reproduce (if applicable)

Steps to reproduce the behavior:

  1. Add logger which will show the current progress value;
  2. Go to page which has BottomSheetScaffold structure; bottom sheet is visible in both expanded and collapsed state;
  3. Click on the bottom sheet while it is collapsed and drag it up with intention to expand it;
  4. Observe the progress in the logger.
  5. See error: 1.0 is shown on ly when bottom sheet is fully expanded, no intermediate values were provided.

Expected behavior (if applicable)

When Bottom sheet is expanding, provide the same behavior as when it is collapsing -> show continuous updates of the progress value.

Screenshots? (if applicable)

When expanding: image

When collapsing: image

Environment: (if applicable)

Additional context

n/a

bentrengrove commented 4 months ago

Navigation material has been deprecated in Accompanist as the functionality has been moved to the main Compose libraries. If this bug persists there I suggest filing it at [goo.gle/compose-feedback]()