google / adb-sync

Apache License 2.0
1.08k stars 171 forks source link

Add --copy-links, use stat instead of lstat #16

Closed chatziko closed 5 years ago

chatziko commented 7 years ago

To properly sync symlinks, use stat instead of lstat, otherwise we get the size of the link (instead of the file) and we end up constantly re-pushing everything. Also add a --copy-links/-L option that enables syncing of symlinks, similarly to rsync.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


chatziko commented 7 years ago

CLA signed.

googlebot commented 7 years ago

CLAs look good, thanks!

frnsys commented 6 years ago

Any chance this will be merged?

divVerent commented 5 years ago

I'm gonna check this today. Sorry for extremely late reply.

divVerent commented 5 years ago

Thanks, looks good!

divVerent commented 5 years ago

Oops, broke your change... just manually fixed conflicts.

divVerent commented 5 years ago

Merged now. Thanks!