Perform filename normalization for diff

google / adb-sync

Apache License 2.0

1.08k stars 169 forks source link

Perform filename normalization for diff #20

Open shirayu opened 6 years ago

shirayu commented 6 years ago

Currently a file named to ガールズ.txt is always synchronized with Mac OS which uses HFS+ file system. This is because HFS+ file performs NFD like filename normalization. ガ is U+30AC in NFC and U+30AB U+3099 in NFD.

With this PR, adb-sync performs filename NFC normalization for diff as default. With --no-file-name-normalize, it does not.

divVerent commented 5 years ago

This is tricky - I don't think we should be munging file names by default.

One idea: check if the local file system does this, and only enable it if so. Other idea: for now make it off by default.

divVerent commented 5 years ago

BTW, while at it... could also try case folding as well, to better handle Windows systems. Also as an option.